ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 52706] [PATCH] Make Execute class extensible to allow custom CommandLauncher implementation
Date Wed, 20 Jun 2012 12:38:19 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52706

--- Comment #12 from Vimil <vimilsaju@yahoo.com> ---
(In reply to comment #11)
> We'd need a small manual page like we have for the other tasks and maybe a
> cross-reference to it from exec.
>
I will work on that.

> As tests I'd probably write an AntUnit test that builds a CommandLauncher
> which only echos a message and doesn't do anything else and then assert the
> message is there.

I am not familiar with AntUnit but I can surely learn how it works :) I will
let you know if I get stuck somewhere. 

> 
> Thinking about it, would it be a good idea to have an option to reset the
> CommandLauncher to the default one if it has been changed?
> 
> Let me know if you need any help.

How about an attribute called 'reset' for the CommandLauncherTask that removes
the project reference and the system property if they are set?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message