ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 50781] javac task creates long command line
Date Tue, 22 May 2012 18:39:52 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50781

--- Comment #9 from Jesse Glick <jglick@netbeans.org> ---
BTW the patch as it stands is wrong, since it ignores the documented
firstFileName parameter. What you meant to do is adjust the doc for this
parameter to indicate that it could in fact be zero even when there are some
options; and change callers (esp. JavacExternal but also perhaps
AptExternalCompilerAdapter) to pass zero by default rather than cmd.size().

(The patch also, curiously, behaves as if firstFileName=1 rather than =0: it
copies over the first real arg unchanged, then adds the @rest. This could fail
in case the first arg happened to be something very long, such as
-J-Xbootclasspath/p:/some/long/path/to/compiler/patch.jar.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message