ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52743] New: An incomplete fix for the resource leak bug in ReplaceRegExp.java
Date Thu, 23 Feb 2012 08:40:20 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52743

             Bug #: 52743
           Summary: An incomplete fix for the resource leak bug in
                    ReplaceRegExp.java
           Product: Ant
           Version: unspecified
          Platform: PC
            Status: NEW
          Severity: critical
          Priority: P2
         Component: Core
        AssignedTo: notifications@ant.apache.org
        ReportedBy: lianggt08@sei.pku.edu.cn
    Classification: Unclassified


The fix revisions 270637, 272826, and 905179 were aimed to remove resource leak
bugs on the Reader object "r", the Writer object "w", the BufferedWriter object
"bw" in the method "doReplace"of the file
"/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java"
, but it is incomplete.

In the head revision (rev1037691), there is still some problem: 
1. the BufferedReader object "br" created at line 369 isn't closed, and  it
will be leaked. 

The best way to close such resource objects is putting such close operations
for all resource objects in the finaly block of a try-catch-finally structure
and then putting all other code in a try block.

The problem still exists.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message