ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52344] Add -sigalg and -digestalg support to the signjar task
Date Mon, 19 Dec 2011 06:37:58 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52344

--- Comment #3 from Stefan Bodewig <bodewig@apache.org> 2011-12-19 06:37:58 UTC ---
Patch looks reasonable except that I'd keep the field private.  It may be
better to move this to AbstractJarSigner (even though VerifyJar is and probably
has ever been dead).

Do we need to adapt the IsSigned condition as well?

Tests for signjar are AntUnit based in
http://svn.apache.org/repos/asf/ant/core/trunk/src/tests/antunit/taskdefs/signjar-test.xml

It would be nice if you could provide a blurb for the task's manual page (in
particular one that described the problems with Android/Java7) as well.  It is
in http://svn.apache.org/repos/asf/ant/core/trunk/manual/Tasks/signjar.html

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message