Return-Path: X-Original-To: apmail-ant-notifications-archive@minotaur.apache.org Delivered-To: apmail-ant-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B5CC994B0 for ; Tue, 22 Nov 2011 12:52:19 +0000 (UTC) Received: (qmail 39909 invoked by uid 500); 22 Nov 2011 12:52:19 -0000 Delivered-To: apmail-ant-notifications-archive@ant.apache.org Received: (qmail 39873 invoked by uid 500); 22 Nov 2011 12:52:19 -0000 Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ant.apache.org Delivered-To: mailing list notifications@ant.apache.org Received: (qmail 39864 invoked by uid 99); 22 Nov 2011 12:52:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2011 12:52:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2011 12:52:17 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id 4F2484FEC6; Tue, 22 Nov 2011 12:51:56 +0000 (UTC) From: bugzilla@apache.org To: notifications@ant.apache.org Subject: DO NOT REPLY [Bug 42046] properties get double-expanded in macrodefs Date: Tue, 22 Nov 2011 12:51:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Core tasks X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: bodewig@apache.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: notifications@ant.apache.org X-Bugzilla-Target-Milestone: 1.8.3 X-Bugzilla-Changed-Fields: Status Resolution Target Milestone Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=42046 Stefan Bodewig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED Target Milestone|--- |1.8.3 --- Comment #7 from Stefan Bodewig 2011-11-22 12:51:55 UTC --- The resons for the propertyhelper-test failure turned out to be more subtle. after applying your patch the test was comparing the o.toString() for arg2 to o and of course they were no the same. I've modified the test to use a property who's value is a string and it passes. What is happening here is that the loadproperties task doesn't work as expected b the test when expanding properties with non-string values. I.e. this is another case where the double-expansion of properties cause a false positive unit test. svn revision 1204961 contains the patch and disabled the failing tests that I'm going to address separately. Thanks for your patience. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.