ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42046] properties get double-expanded in macrodefs
Date Thu, 17 Nov 2011 16:13:00 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=42046

--- Comment #6 from Stefan Bodewig <bodewig@apache.org> 2011-11-17 16:13:00 UTC ---
I'm again trying to get this resolved.  With your patch now not only
propertyhelper-test but also property-test fails.

Interestingly the property-test failure is a good one as the buggy behavior of
assertPropertyEquals of bug 41400 hides the actual failure.  See the commented
out alternative way of verifying the property value in svn revision 1203226

In the case of properthelper-test I've tracked it down to the point where
<equals> says the objects are different.  In fact, <equals> doesn't see any
objects but rather the string ${object}.  This ${object} is supposed to be
resolved into an Object instance by a custom property helper - and it is inside
the error message, but not when passed to <equals>.

So whatever it is that performs the second expansion on macroinstance
attributes doesn't seem to consult all propertyhelpers, while the first
invocation that your patch removes does.

This is more thinking out loud as I will try to investigate this case further
myself, but maybe anybody else sees where we are going wrong before I do.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message