ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51602] zip reports "not found" when basedir attribute used with fileset
Date Sat, 06 Aug 2011 05:07:59 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51602

--- Comment #3 from Stefan Bodewig <bodewig@apache.org> 2011-08-06 05:07:59 UTC ---
(In reply to comment #2)

> Tried to subscribe to your mailing list to respond there (as requested), but my
> sub request keeps getting bounced by the Apache mailserver as spam:
> Sorry, we were unable to deliver your message to the following address.
> 
> <user-sc.1312555838.jpmeeinonbbcmahgmdpn-lothsahn=yahoo.com@ant.apache.org>:
> Remote host said: 552 spam score (6.2) exceeded threshold
> (DCC_CHECK,FREEMAIL_FROM,HTML_MESSAGE,MIME_HTML_MOSTLY,RCVD_IN_DNSWL_NONE,SPF_PASS
> ) [BODY]

Learn not to send HTML emails ;-)

> Thank you for looking at this bugreport.  You stated:
> basedir and nested filesets are totally unrelated.  With basedir you create an
> implicit fileset with its dir attribute set to the value given in basedir. 
> I.e. you now have two completely independent filesets.
> 
> 
> I don't think this is true. In the above example, my project basedir is
> "C:\build".  When I specify basedir attribute, ant creates the zip based on the
> specified basedir.  

Yes, this is the implicit fileset at work, the one using the task's basedir
attribute that you didn't spell out explicitly.

> "Don't use it [basedir] for anythig, only use nested filesets (or other
> suitable resource collections)."
> 
> If we really want people to avoid using the basedir attribute (which I am
> totally fine with, as your suggested example does workaround the issue), can we
> simply mark basedir as deprecated in the ant Zip target documentation?

There are valid use-cases where basedir just means less typing

<zip basedir="foo" destfile="foo.zip"/>

rather than

<zip destfile="foo.zip">
  <fileset dir="foo"/>
</zip>

So maybe my statement has been too strong.  But you shouldn't mix basedir
and filesets.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message