ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jgl...@apache.org
Subject svn commit: r1148910 - in /ant/core/trunk/src/main/org/apache/tools/ant: Diagnostics.java IntrospectionHelper.java
Date Wed, 20 Jul 2011 19:22:19 GMT
Author: jglick
Date: Wed Jul 20 19:22:19 2011
New Revision: 1148910

URL: http://svn.apache.org/viewvc?rev=1148910&view=rev
Log:
FindBugs.

Modified:
    ant/core/trunk/src/main/org/apache/tools/ant/Diagnostics.java
    ant/core/trunk/src/main/org/apache/tools/ant/IntrospectionHelper.java

Modified: ant/core/trunk/src/main/org/apache/tools/ant/Diagnostics.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/Diagnostics.java?rev=1148910&r1=1148909&r2=1148910&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/Diagnostics.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/Diagnostics.java Wed Jul 20 19:22:19 2011
@@ -362,6 +362,7 @@ public final class Diagnostics {
         } catch (SecurityException  e) {
             ignoreThrowable(e);
             out.println("Access to System.getProperties() blocked " + "by a security manager");
+            return;
         }
         for (Enumeration keys = sysprops.propertyNames();
             keys.hasMoreElements();) {

Modified: ant/core/trunk/src/main/org/apache/tools/ant/IntrospectionHelper.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/IntrospectionHelper.java?rev=1148910&r1=1148909&r2=1148910&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/IntrospectionHelper.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/IntrospectionHelper.java Wed Jul 20 19:22:19
2011
@@ -1643,7 +1643,7 @@ public final class IntrospectionHelper {
     }
 
 
-    private class MethodAndObject {
+    private static class MethodAndObject {
         private Method method;
         private Object object;
         public MethodAndObject(Method method, Object object) {



Mime
View raw message