ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49624] [PATCH] Add Git and Mercurial special files to default excludes
Date Thu, 05 Aug 2010 14:17:54 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49624

--- Comment #4 from Dominique Devienne <ddevienne@gmail.com> 2010-08-05 10:17:49 EDT
---
Well, I kinda stand by what I said then, which btw was just my opinion and I
didn't -1 your proposed change, I merely argued users already had the
flexibility to do it w/o code changes.

I do acknowledge it's a PITA to define all the exclude patterns oneself,
especially since <defaultexcludes> doesn't appear to allow loading them from a
file for example.

But isn't adding so many patterns to default excludes making all builds a
little slower every time?

IMHO, ideally we could ship some kind of resource file(s) that contains all
submitted default excludes, categorized by scm names (and editors possibly),
and the users can then just say <defaultexcludes categories="git, vi, emacs"/>
or
<defaultexcludes><fileset dir="..."
includes="*-excludes.properties"/></defaultexcludes>, to limit the number of
such patterns to the minimum required.

Git and Hg are very popular nowdays, so sure, lets add them, yet I feel we
shouldn't have to. My $0.02...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message