ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gscok...@apache.org
Subject svn commit: r953157 - /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
Date Wed, 09 Jun 2010 20:55:20 GMT
Author: gscokart
Date: Wed Jun  9 20:55:19 2010
New Revision: 953157

URL: http://svn.apache.org/viewvc?rev=953157&view=rev
Log:
full_exclusion and exclusion_parts are reported as checkstyle error, and I don't see the purpose
of all final used for local variable

Modified:
    ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java

Modified: ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java?rev=953157&r1=953156&r2=953157&view=diff
==============================================================================
--- ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
(original)
+++ ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
Wed Jun  9 20:55:19 2010
@@ -478,25 +478,25 @@ public class PomModuleDescriptorBuilder 
     }
 
     private static List /*<ModuleId>*/ getDependencyMgtExclusions(
-                                final ModuleDescriptor descriptor,
-                                final String groupId,
-                                final String artifactId) {
-        final String exclusionPrefix = getDependencyMgtExtraInfoPrefixForExclusion(
+                                ModuleDescriptor descriptor,
+                                String groupId,
+                                String artifactId) {
+        String exclusionPrefix = getDependencyMgtExtraInfoPrefixForExclusion(
                 groupId, artifactId);
-        final List /*<ModuleId>*/ exclusionIds = new LinkedList /*<ModuleId>*/
();
-        final Map /*<String,String>*/ extras = descriptor.getExtraInfo();
+        List /*<ModuleId>*/ exclusionIds = new LinkedList /*<ModuleId>*/ ();
+        Map /*<String,String>*/ extras = descriptor.getExtraInfo();
         for (final Iterator entIter = extras.entrySet().iterator(); entIter.hasNext();) {
-            final Map.Entry /*<String,String>*/ ent = (Map.Entry) entIter.next();
-            final String key = (String) ent.getKey();
+            Map.Entry /*<String,String>*/ ent = (Map.Entry) entIter.next();
+            String key = (String) ent.getKey();
             if (key.startsWith(exclusionPrefix)) {
-                final String full_exclusion = (String) ent.getValue();
-                final String[] exclusion_parts = full_exclusion.split(EXTRA_INFO_DELIMITER);
-                if (exclusion_parts.length != 2) {
-                    Message.error(WRONG_NUMBER_OF_PARTS_MSG + exclusion_parts.length + "
: "
-                            + full_exclusion);
+                String fullExclusion = (String) ent.getValue();
+                String[] exclusionParts = fullExclusion.split(EXTRA_INFO_DELIMITER);
+                if (exclusionParts.length != 2) {
+                    Message.error(WRONG_NUMBER_OF_PARTS_MSG + exclusionParts.length + " :
"
+                            + fullExclusion);
                     continue;
                 }
-                exclusionIds.add(ModuleId.newInstance(exclusion_parts[0], exclusion_parts[1]));
+                exclusionIds.add(ModuleId.newInstance(exclusionParts[0], exclusionParts[1]));
             }
         }
 



Mime
View raw message