ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Quinn (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IVY-1170) LatestVersionMatcher.needModuleDescriptor() does not honor custom statuses
Date Sat, 29 May 2010 07:39:35 GMT

    [ https://issues.apache.org/jira/browse/IVY-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873253#action_12873253
] 

Carl Quinn commented on IVY-1170:
---------------------------------

Could someone take a look at this patch and apply it towards 2.2.0 RC? Or let me know if they
see a problem with it?

We are currently running a locally built Ivy version, and I'd like to get this officialized
if possible.

> LatestVersionMatcher.needModuleDescriptor() does not honor custom statuses
> --------------------------------------------------------------------------
>
>                 Key: IVY-1170
>                 URL: https://issues.apache.org/jira/browse/IVY-1170
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0
>            Reporter: Carl Quinn
>         Attachments: ivy-1170.patch
>
>
> While tracking down some unexpected behavior in our Ivy-based build system, I ran across
what looks like a bug in LatestVersionMatcher.needModuleDescriptor(). In that method, it has
a hard-coded check for "latest.integration" to determine when to not require a module descriptor
and just grab the newest thing.
>     public boolean needModuleDescriptor(ModuleRevisionId askedMrid, ModuleRevisionId
foundMrid) { 
>         return !"latest.integration".equals(askedMrid.getRevision()); 
>     } 
> In our case, we have redefined our status to be the maven-like names: 
>     <statuses default="snapshot"> 
>         <status name="release" integration="false"/> 
>         <status name="snapshot" integration="true"/> 
>     </statuses> 
> Where in our case "snapshot" replaces "integration". And this LatestVersionMatcher then
fails to allow "latest.snapshot" to grab artifacts w/o module descriptors. (all those old
jars that I haven't Ivy-fied yet :) 
> I will work on developing a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message