ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maarten Coene (JIRA)" <>
Subject [jira] Resolved: (IVY-1170) LatestVersionMatcher.needModuleDescriptor() does not honor custom statuses
Date Mon, 31 May 2010 21:01:40 GMT


Maarten Coene resolved IVY-1170.

    Resolution: Fixed

I've applied your patch to SVN trunk with one small modification: I removed the check for
status.isIntegration() to see if the moduledescriptor is needed.

Thanks for the contribution!

> LatestVersionMatcher.needModuleDescriptor() does not honor custom statuses
> --------------------------------------------------------------------------
>                 Key: IVY-1170
>                 URL:
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0
>            Reporter: Carl Quinn
>            Assignee: Maarten Coene
>             Fix For: 2.2.0-RC1
>         Attachments: ivy-1170.patch
> While tracking down some unexpected behavior in our Ivy-based build system, I ran across
what looks like a bug in LatestVersionMatcher.needModuleDescriptor(). In that method, it has
a hard-coded check for "latest.integration" to determine when to not require a module descriptor
and just grab the newest thing.
>     public boolean needModuleDescriptor(ModuleRevisionId askedMrid, ModuleRevisionId
foundMrid) { 
>         return !"latest.integration".equals(askedMrid.getRevision()); 
>     } 
> In our case, we have redefined our status to be the maven-like names: 
>     <statuses default="snapshot"> 
>         <status name="release" integration="false"/> 
>         <status name="snapshot" integration="true"/> 
>     </statuses> 
> Where in our case "snapshot" replaces "integration". And this LatestVersionMatcher then
fails to allow "latest.snapshot" to grab artifacts w/o module descriptors. (all those old
jars that I haven't Ivy-fied yet :) 
> I will work on developing a patch.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message