ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Quinn (JIRA)" <>
Subject [jira] Updated: (IVY-1170) LatestVersionMatcher.needModuleDescriptor() does not honor custom statuses
Date Fri, 12 Feb 2010 23:20:27 GMT


Carl Quinn updated IVY-1170:

    Attachment: ivy-1170.patch

I've attached a patch which makes the choice of the tail for "latest.integration" be dynamically
selected from the configured statuses. With a default setup, this will remain "latest.integration",
but when a different status is the least released, it will be used instead, such as "latest.snapshot".

I've included a unit test as well, although it is quite low-level and white box. But all tests
continue to pass.

Let me know if this is ok, or if it needs more work.


> LatestVersionMatcher.needModuleDescriptor() does not honor custom statuses
> --------------------------------------------------------------------------
>                 Key: IVY-1170
>                 URL:
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0
>            Reporter: Carl Quinn
>         Attachments: ivy-1170.patch
> While tracking down some unexpected behavior in our Ivy-based build system, I ran across
what looks like a bug in LatestVersionMatcher.needModuleDescriptor(). In that method, it has
a hard-coded check for "latest.integration" to determine when to not require a module descriptor
and just grab the newest thing.
>     public boolean needModuleDescriptor(ModuleRevisionId askedMrid, ModuleRevisionId
foundMrid) { 
>         return !"latest.integration".equals(askedMrid.getRevision()); 
>     } 
> In our case, we have redefined our status to be the maven-like names: 
>     <statuses default="snapshot"> 
>         <status name="release" integration="false"/> 
>         <status name="snapshot" integration="true"/> 
>     </statuses> 
> Where in our case "snapshot" replaces "integration". And this LatestVersionMatcher then
fails to allow "latest.snapshot" to grab artifacts w/o module descriptors. (all those old
jars that I haven't Ivy-fied yet :) 
> I will work on developing a patch.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message