ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 41400] [PATCH] properties get double expanded in <assertPropertyEquals>
Date Tue, 05 Jan 2010 06:51:38 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=41400

--- Comment #7 from Markus Kahl <machisuji@googlemail.com> 2010-01-04 22:51:34 UTC ---
(In reply to comment #6)
> After applying the patch one of Ant's tests (propertyhelper-test,
> testLoadProperties) fails:
> 
> Expected property 'object2' to have value 'java.lang.Object@178acba' but was
> 'java.lang.Object@178acba'
> at line 124 , column 65
> 
> and it is not obvious to me where the current test relies on double expansion. 
> The problem may as well be inside AntUnit.
> 
> Given that we are only days away from Ant 1.8.0, I'd prefer to defer looking
> into it until Ant 1.8.1.

Sorry that I haven't run the tests before even sending in the patch.
I still couldn't get the tests running because for some reason
junit.framework.TestCase isn't found and so all the tests fail.

JUnit is definitely in the classpath, though. :/


I recognize that error message. When I tried to fix the bug first I made
a change directly in MacroInstance.java which was rather a hack to see what was
happening.
When a return value in macroSubs() started with $ I just added another one. :D
The result were error messages like that one you got.
That is during the comparison of the values the property wasn't double-expanded
but then again in the output, I think.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message