Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ant.apache.org
Message-ID: <2113658396.1256335799440.JavaMail.jira@brutus>
Date: Fri, 23 Oct 2009 22:09:59 +0000 (UTC)
From: "Maarten Coene (JIRA)" <jira@apache.org>
To: notifications@ant.apache.org
Subject: [jira] Resolved: (IVY-1118) IvyNodeEviction.cleanEvicted has bad
 comparison logic
In-Reply-To: <109630467.1251897032688.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/IVY-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maarten Coene resolved IVY-1118.
--------------------------------

       Resolution: Fixed
    Fix Version/s: trunk
         Assignee: Maarten Coene

Fixed in SVN trunk.
Thanks for reporting this!

Maarten

> IvyNodeEviction.cleanEvicted has bad comparison logic
> -----------------------------------------------------
>
>                 Key: IVY-1118
>                 URL: https://issues.apache.org/jira/browse/IVY-1118
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0-RC2
>            Reporter: Dave Brosius
>            Assignee: Maarten Coene
>            Priority: Minor
>             Fix For: trunk
>
>
> clean evicted compares an IvyNode to an IvyNodeEviction which will always be false
> private void cleanEvicted() {
>         // check if it was evicted by a node that we are now the real node for
>         for (Iterator iter = evicted.keySet().iterator(); iter.hasNext();) {
>             String rootModuleConf = (String) iter.next();
>             EvictionData ed = (EvictionData) evicted.get(rootModuleConf);
>             Collection sel = ed.getSelected();
>             if (sel != null) {
>                 for (Iterator iterator = sel.iterator(); iterator.hasNext();) {
>                     IvyNode n = (IvyNode) iterator.next();
>                     if (n.getRealNode().equals(this)) {                                     <<<<<<<<<<<<<<<<<<<<<<<<
>                         // yes, we are the real node for a selected one !
>                         // we are no more evicted in this conf !
>                         iter.remove();
>                     }
>                 }
>             }
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.