ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jaco uys (JIRA)" <j...@apache.org>
Subject [jira] Updated: (IVY-1133) ChainResolver Checkmodified override bug
Date Sat, 03 Oct 2009 16:13:23 GMT

     [ https://issues.apache.org/jira/browse/IVY-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

jaco uys updated IVY-1133:
--------------------------

    Description: 
I have found an issue some time ago with resolving dependencies via a
chain resolver.
I can not remember the exact scenario, but had to do with resolving A
-> B -> C where A and C comes from a local repo and B from a 'shared'
repo.

The issue seems to be with ChainResolver that overrides 'public void
setCheckmodified(boolean check)'. The 'checkModified' value is not
propagated through to the base class 'AbstractResolver'. This results
in the 'AbstractResolver.getCacheOptions(ResolveData data)' behaving
incorrectly when creating the 'CacheMetadataOptions'.

The fix I made was to change the 'ChainResolver.setCheckmodified' to:

public void setCheckmodified(boolean check) {
       checkmodified = Boolean.valueOf(check);
       super.setCheckmodified(check);
}

I've attached an svn patch for it.


  was:
I have found an issue some time ago with resolving dependencies via a
chain resolver.
I can not remember the exact scenario, but had to do with resolving A
-> B -> C where A and C comes from a local repo and B from a 'shared'
repo.

The issue seems to be with ChainResolver that overrides 'public void
setCheckmodified(boolean check)'. The 'checkModified' value is not
propagated through to the base class 'AbstractResolver'. This results
in the 'AbstractResolver.getCacheOptions(ResolveData data)' behaving
incorrectly when creating the 'CacheMetadataOptions'.


> ChainResolver Checkmodified override bug
> ----------------------------------------
>
>                 Key: IVY-1133
>                 URL: https://issues.apache.org/jira/browse/IVY-1133
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0-RC2
>            Reporter: jaco uys
>         Attachments: Checkmodified.patch
>
>
> I have found an issue some time ago with resolving dependencies via a
> chain resolver.
> I can not remember the exact scenario, but had to do with resolving A
> -> B -> C where A and C comes from a local repo and B from a 'shared'
> repo.
> The issue seems to be with ChainResolver that overrides 'public void
> setCheckmodified(boolean check)'. The 'checkModified' value is not
> propagated through to the base class 'AbstractResolver'. This results
> in the 'AbstractResolver.getCacheOptions(ResolveData data)' behaving
> incorrectly when creating the 'CacheMetadataOptions'.
> The fix I made was to change the 'ChainResolver.setCheckmodified' to:
> public void setCheckmodified(boolean check) {
>        checkmodified = Boolean.valueOf(check);
>        super.setCheckmodified(check);
> }
> I've attached an svn patch for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message