ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Scheetz (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IVY-1128) SearchEngine.listModules returns MRID without extra attributes.
Date Fri, 02 Oct 2009 00:14:23 GMT

    [ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761419#action_12761419
] 

Michael Scheetz commented on IVY-1128:
--------------------------------------

Maarten,

The list of modules returned by ivy.listModules(criteria, settings.getMatcher(PatternMatcher.REGEXP))
now contain the extra attributes, so that part is fixed.

However, the method does not honor all of the search criteria stated by the ModuleRevisionId.
 That is, the extra attributes are ignored as search parameters.  The returned list contains
all of the modules that match the "org,name,revision" portion of the mrid.  It should return
only the modules which match "org,name,revision,extraAtts".


Michael



> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
>                 Key: IVY-1128
>                 URL: https://issues.apache.org/jira/browse/IVY-1128
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0-RC2
>         Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006 
>            Reporter: Michael Scheetz
>            Assignee: Maarten Coene
>             Fix For: trunk
>
>         Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId,
PatternMatcher) method does not contain any extra attributes.  If extra attributes are passed
in then they should also be added to the returned module.  Without the extra attributes then
then the modules returned are practically useless for any further use.  This method is published
in the Ivy class, too.
> See attached for test and fix patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message