ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 46805] ant exec hangs when invoking "asadmin.bat start-domain"
Date Tue, 27 Oct 2009 17:59:32 GMT

--- Comment #8 from Stefan Bodewig <> 2009-10-27 10:59:32 UTC ---
the code in Ant's trunk is different enough from Ant 1.7.1 that I'd really like
to have confirmation that not closing the streams is really fixing anything
that has been broken before just to avoid adding yet another variable.

The "don't close what you haven't created" argument doesn't really convince me.
 There are situations where you can't create a stream but are the only one who
knows when to close it - in this situation you are the only one who can close
the stream and should better do it.  The Java class library has many such
cases, see ZipFile.getInputStream or URLConnection.getInputStream.  In some
cases there is a hint of documentation of what is expected from the API user
(ResultSet.get*Stream) but in most cases - including the Process.get*Stream
methods - there is none.

There simply doesn't seem to be a simple testcase that would allow us to test
the current code base against anything that still exhibits problems and if you
can't test trunk, we'll have to wait until the first release candidate for
1.8.0 is out.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

View raw message