Return-Path: 
 <notifications-return-9746-apmail-ant-notifications-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-notifications-archive@minotaur.apache.org
Received: (qmail 4051 invoked from network); 1 Sep 2009 14:56:55 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 1 Sep 2009 14:56:55 -0000
Received: (qmail 68527 invoked by uid 500); 1 Sep 2009 14:56:55 -0000
Delivered-To: apmail-ant-notifications-archive@ant.apache.org
Received: (qmail 68503 invoked by uid 500); 1 Sep 2009 14:56:55 -0000
Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@ant.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@ant.apache.org>
List-Post: <mailto:notifications@ant.apache.org>
List-Id: <notifications.ant.apache.org>
Reply-To: dev@ant.apache.org
Delivered-To: mailing list notifications@ant.apache.org
Received: (qmail 68494 invoked by uid 99); 1 Sep 2009 14:56:55 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:56:55 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:56:52 +0000
Received: by brutus.apache.org (Postfix, from userid 33)
	id 753FD234C045; Tue,  1 Sep 2009 07:56:31 -0700 (PDT)
From: bugzilla@apache.org
To: notifications@ant.apache.org
Subject: DO NOT REPLY [Bug 45439] Memory growth during copy with use of
 FilterReader
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ant
X-Bugzilla-Component: Core tasks
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: bodewig@apache.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: notifications@ant.apache.org
X-Bugzilla-Target-Milestone: 1.8.0
X-Bugzilla-Changed-Fields: Status Resolution Target Milestone
In-Reply-To: <bug-45439-48744@https.issues.apache.org/bugzilla/>
References: <bug-45439-48744@https.issues.apache.org/bugzilla/>
X-Bugzilla-URL: https://issues.apache.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Message-Id: <20090901145631.753FD234C045@brutus.apache.org>
Date: Tue,  1 Sep 2009 07:56:31 -0700 (PDT)
X-Virus-Checked: Checked by ClamAV on apache.org

https://issues.apache.org/bugzilla/show_bug.cgi?id=45439


Stefan Bodewig <bodewig@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |1.8.0


--- Comment #1 from Stefan Bodewig <bodewig@apache.org> 2009-09-01 07:56:29 PDT ---
I think svn revision 810080 fixes the memory leak in a clean way - except when
something prior to returning the reader in ChainReaderHelper throws an
exception, that is.

If you <typedef> or <componentdef> your filterreader and don't use the
<filterreader classname="..."> syntax only a single instance will be used to
copy all files, which should avoid the problem in 1.7.x altogether.

Regarding your hack: it would be safer to perform your action in an overridden
close method (which basically is what my patch does at the chain level).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.