ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucas Lech (JIRA)" <j...@apache.org>
Subject [jira] Created: (IVY-1120) IvyBuildNumber non-deterministic behaviour
Date Thu, 10 Sep 2009 16:19:58 GMT
IvyBuildNumber non-deterministic behaviour
------------------------------------------

                 Key: IVY-1120
                 URL: https://issues.apache.org/jira/browse/IVY-1120
             Project: Ivy
          Issue Type: Bug
          Components: Ant
    Affects Versions: 2.1.0-RC2
         Environment: ant 1.7.1,  windows xp
            Reporter: Lucas Lech
            Priority: Trivial


IvyBuildNumber.java -> doExecute()

creates an inline patternMatcher with this method:

{code:title=IvyBuildNumber.java|borderStyle=solid}

public Matcher getMatcher(String expression) {
                if ((expression == organisation)
                        || (expression == module)
                        || (expression == branch)) {
                    return exact.getMatcher(expression);
                }
                return regexp.getMatcher(expression);
            }
{code}

I'm guessing the == comparison is a typo ? Shouldn't it be saying *.equals* ?
I've been having issues with this task - non-deterministic results - I got down in my debug
to this place where I get wrong matcher when 
*reference address comparison* fails.

Lucas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message