ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] Created: (IVY-1118) IvyNodeEviction.cleanEvicted has bad comparison logic
Date Wed, 02 Sep 2009 13:10:32 GMT
IvyNodeEviction.cleanEvicted has bad comparison logic
-----------------------------------------------------

                 Key: IVY-1118
                 URL: https://issues.apache.org/jira/browse/IVY-1118
             Project: Ivy
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.1.0-RC2
            Reporter: Dave Brosius
            Priority: Minor


clean evicted compares an IvyNode to an IvyNodeEviction which will always be false

private void cleanEvicted() {
        // check if it was evicted by a node that we are now the real node for
        for (Iterator iter = evicted.keySet().iterator(); iter.hasNext();) {
            String rootModuleConf = (String) iter.next();
            EvictionData ed = (EvictionData) evicted.get(rootModuleConf);
            Collection sel = ed.getSelected();
            if (sel != null) {
                for (Iterator iterator = sel.iterator(); iterator.hasNext();) {
                    IvyNode n = (IvyNode) iterator.next();
                    if (n.getRealNode().equals(this)) {                                  
  <<<<<<<<<<<<<<<<<<<<<<<<
                        // yes, we are the real node for a selected one !
                        // we are no more evicted in this conf !
                        iter.remove();
                    }
                }
            }
        }
    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message