ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39655] Manifest task does not merge Class-Path in update mode and overwrites the old contents
Date Thu, 20 Aug 2009 09:20:57 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=39655


Stefan Bodewig <bodewig@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.8.0
           Severity|normal                      |enhancement


--- Comment #2 from Stefan Bodewig <bodewig@apache.org> 2009-08-20 02:20:54 PDT ---
The code for Class-Path isn't there to merge Class-Path attributes from
different manifests but to merge different Class-Path attributes inside the
same section of the same manifest - so it is not really related to merging at
all.

See the warning generated in line 622 of svn revision 802486

                        warnings.addElement("Multiple Class-Path attributes "
                            + "are supported but violate the Jar "
                            + "specification and may not be correctly "
                            + "processed in all environments");

Merging of manifests as done by the tasks update-mode means add new attributes
and overwrite existing attributes, including Class-Path and this is what the
current code does.

See the comment in line 487 of said revision

                // the merge file *always* wins, even for Class-Path

I don't recall why Ant supports multiple Class-Path attributes but this really
is the only purpose of the existing code.

As you said, it may be useful to have a separate option to merge Class-Path
attributes and your patch contains most of what would be needed to implement
it.  Am looking into it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message