ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47421] tar task does not flush the buffer correctly for a short block
Date Tue, 30 Jun 2009 04:27:11 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47421


Stefan Bodewig <bodewig@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |1.8.0




--- Comment #2 from Stefan Bodewig <bodewig@apache.org>  2009-06-29 21:27:10 PST ---
your patch would lead to tar archives whose last block was incomplete. 
Following the comments in readBlock this may be what other archivers do as
well, but it seems to violate the specification (don't have any source for the
spec right now).

I think the cleaner approach would be to zero out the unused part of the block,
this could be done in writeBlock after the block has been written.  This has
been done in svn revision 789556 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=789556
)

Could you please verify that this approach fixes the problem you see (my tar
implementations didn't have any problem with the old Ant code).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message