ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47373] Zip.java patch to support setting last modified date
Date Sun, 21 Jun 2009 22:37:40 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47373





--- Comment #14 from Mark Farnsworth <farnsworth2008@gmail.com>  2009-06-21 15:37:36
PST ---
Created an attachment (id=23841)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23841)
Patch ready for code review

This patch can be applied to SVN revision 787061 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=787061
); trunk or ANT_17_BRANCH.

The patch adds support for Touch style datetime and pattern attributes to the
Zip task.  The task includes the changes to Zip.java and changes to
documentation files zip.html, ear.html, jar.html, and war.html.  

The scope of the patch is limited to zip, jar, war, and ear.  This patch does
not address Tar because while conceptually similar the Tar task does not have a
common base and as such I think it would best to create a different task item
for Tar.

The patch also does not implement anything with ZipFileSet because once again I
view that this would be better addressed as a separate issue/patch.  Even if we
decide to support this touch style syntax at the ZipFileSet level we would
still need to have the work of this patch because many users of Zip,Jar,War,Ear
tasks do not use ZipFileSet and as such core support for the feature needs to
be at the Zip.java level.  

We can later add support for a similar feature at ZipFileSet and in Tar but to
keep a handle of patch scope I would view these as separate issues.

When reviewing the patch, please provide comments here and/or send me an email
(farnsworth2008@gmail.com).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message