Return-Path: Delivered-To: apmail-ant-notifications-archive@minotaur.apache.org Received: (qmail 50592 invoked from network); 9 Apr 2009 09:28:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Apr 2009 09:28:17 -0000 Received: (qmail 56176 invoked by uid 500); 9 Apr 2009 09:28:17 -0000 Delivered-To: apmail-ant-notifications-archive@ant.apache.org Received: (qmail 56106 invoked by uid 500); 9 Apr 2009 09:28:16 -0000 Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ant.apache.org Delivered-To: mailing list notifications@ant.apache.org Received: (qmail 56097 invoked by uid 99); 9 Apr 2009 09:28:16 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2009 09:28:16 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2009 09:28:14 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id EB1E7234C045; Thu, 9 Apr 2009 02:27:53 -0700 (PDT) From: bugzilla@apache.org To: notifications@ant.apache.org Subject: DO NOT REPLY [Bug 47002] junitreport: expose classpath of internal XSLTProcess task X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Optional Tasks X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: Martin.vGagern@gmx.net X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: notifications@ant.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <20090409092753.EB1E7234C045@brutus.apache.org> Date: Thu, 9 Apr 2009 02:27:53 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=47002 --- Comment #1 from Martin von Gagern 2009-04-09 02:27:52 PST --- Created an attachment (id=23470) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23470) Expose classpath and factory This patch creates the nested XSLTProcess at creation of the AggregateTransformer, not upon execution of the transformation. This way it is much easier to simply wrap parts of the interface I'd like to expose, like the new and nested elements, but also the existing elements. I haven't called XSLTProcess.init(), as the previous code didn't do that either. I don't fully understand the difference between init() and a constructor, but it might be a good thing to init the task somewhere. The approach I chose is something like a whitelist delegation: the XSLTProcess is a private member, and only selected methods of its interface are wrapped and thus exposed to be configured. As an alternative, one could do something like a blacklist delegation by deriving a class from XSLTProcess and forbidding access to certain settings by ovverriding the corresponding methods and throwing exceptions therein. In that case, one might even turn the class derived from XSLTProcess into a nested element, which would be probably much clearer, as it would be configured in the same way that a top-level task is. I didn't choose this approach in my patch for now, but if you prefer it, I can implement that as well. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.