Return-Path: 
 <notifications-return-7486-apmail-ant-notifications-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-notifications-archive@minotaur.apache.org
Received: (qmail 15194 invoked from network); 24 Feb 2009 18:52:00 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 24 Feb 2009 18:52:00 -0000
Received: (qmail 44567 invoked by uid 500); 24 Feb 2009 18:52:00 -0000
Delivered-To: apmail-ant-notifications-archive@ant.apache.org
Received: (qmail 44544 invoked by uid 500); 24 Feb 2009 18:52:00 -0000
Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@ant.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@ant.apache.org>
List-Post: <mailto:notifications@ant.apache.org>
List-Id: <notifications.ant.apache.org>
Reply-To: dev@ant.apache.org
Delivered-To: mailing list notifications@ant.apache.org
Received: (qmail 44535 invoked by uid 99); 24 Feb 2009 18:52:00 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2009 10:52:00 -0800
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2009 18:51:58 +0000
Received: by brutus.apache.org (Postfix, from userid 33)
	id 4DE21234C48D; Tue, 24 Feb 2009 10:51:37 -0800 (PST)
From: bugzilla@apache.org
To: notifications@ant.apache.org
Subject: DO NOT REPLY [Bug 32526] Add "whenempty" attribute to <fileset>
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: newchanged
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ant
X-Bugzilla-Component: Core tasks
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: mikecepek@yahoo.com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: notifications@ant.apache.org
X-Bugzilla-Target-Milestone: 1.7.0
X-Bugzilla-Changed-Fields: 
In-Reply-To: <bug-32526-48744@https.issues.apache.org/bugzilla/>
References: <bug-32526-48744@https.issues.apache.org/bugzilla/>
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Message-Id: <20090224185137.4DE21234C48D@brutus.apache.org>
Date: Tue, 24 Feb 2009 10:51:37 -0800 (PST)
X-Virus-Checked: Checked by ClamAV on apache.org

https://issues.apache.org/bugzilla/show_bug.cgi?id=32526





--- Comment #14 from Mike Cepek <mikecepek@yahoo.com>  2009-02-24 10:51:35 PST ---
Comment #13 has an acceptable proposal.  A key aspect is that it's integral to
the tarfileset, not requiring a separate set definition linked through a refid.
 It's a big win to keep it all together in the same task.

Another advantage is being able to bracket wildcarded include specifications,
which otherwise would be uncheckable.

However, using wildcards breaks the strictness, since an explicitly named file
which doesn't exist could be masked by a new wildcarded file.  To solve this,
wildcards could simply be put into their own set(s):

     <tarfileset dir="${dist}" username="admin" group="admin"
             minFileCount="3" maxFilecount="3">
         <include name="lib/my-main.jar" />
         <include name="tools/lib/my-tools.jar" />
         <include name="conf/VERSION" />
     </tarfileset>
     <tarfileset dir="${dist}" username="admin" group="admin"
             minFileCount="5" maxFilecount="10">
         <include name="**/*.jar"/>
     </tarfileset>

I had a completely different idea.  What about a new fileset attribute besides
<filename> and <include>, something like <exact name="foo.bar"> which fails if
the file doesn't exist.  It would be nice to push the checking down to that
level, even to the point of having the maxCount and minCount settings there
(instead of for the fileset as a whole).

BTW, I'm fine relegating this discussion to the users list.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.