ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 32526] Add "whenempty" attribute to <fileset>
Date Tue, 24 Feb 2009 18:51:37 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=32526





--- Comment #14 from Mike Cepek <mikecepek@yahoo.com>  2009-02-24 10:51:35 PST ---
Comment #13 has an acceptable proposal.  A key aspect is that it's integral to
the tarfileset, not requiring a separate set definition linked through a refid.
 It's a big win to keep it all together in the same task.

Another advantage is being able to bracket wildcarded include specifications,
which otherwise would be uncheckable.

However, using wildcards breaks the strictness, since an explicitly named file
which doesn't exist could be masked by a new wildcarded file.  To solve this,
wildcards could simply be put into their own set(s):

     <tarfileset dir="${dist}" username="admin" group="admin"
             minFileCount="3" maxFilecount="3">
         <include name="lib/my-main.jar" />
         <include name="tools/lib/my-tools.jar" />
         <include name="conf/VERSION" />
     </tarfileset>
     <tarfileset dir="${dist}" username="admin" group="admin"
             minFileCount="5" maxFilecount="10">
         <include name="**/*.jar"/>
     </tarfileset>

I had a completely different idea.  What about a new fileset attribute besides
<filename> and <include>, something like <exact name="foo.bar"> which fails
if
the file doesn't exist.  It would be nice to push the checking down to that
level, even to the point of having the maxCount and minCount settings there
(instead of for the fileset as a whole).

BTW, I'm fine relegating this discussion to the users list.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message