ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 4752] Make Ant report an error when an undefined property is referenced.
Date Thu, 30 Oct 2008 14:33:02 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=4752





--- Comment #4 from Ville Oikarinen <ville@oikarinen.org>  2008-10-30 07:33:01 PST ---
Thanks Matt, but we are not there yet.

The apidoc at

http://www.dpml.net/api/ant/1.6.4/org/apache/tools/ant/PropertyHelper.html#getUserProperty(java.lang.String,
java.lang.String)

seems to point at the method responsible for resolving a property. But the
contract seems to be to return null for undefined properties.

Maybe I should overrid this method like this:
public java.lang.Object getUserProperty(java.lang.String ns,
                                        java.lang.String name) {
  Object retval = super.getUserProperty(ns,name);
  if(retval == null) throw new SomeException();
  else return retval;
}

How will this contract violation work (now and in the future)? What should
SomeException be? Etc. Seems that it's the caller's responsibility to handle
null in a different way.

Besides, the apidoc starts with "NOT FINAL. API MAY CHANGE". Doesn't sound like
fun to customize this, does it :)


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message