ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maarten Coene (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (IVY-929) Extra Attributes specified in the Dependency's Module Descriptor are not available to resolvers
Date Mon, 20 Oct 2008 21:52:44 GMT

     [ https://issues.apache.org/jira/browse/IVY-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Maarten Coene resolved IVY-929.
-------------------------------

       Resolution: Fixed
    Fix Version/s: trunk
         Assignee: Maarten Coene

Thank you for your contribution!
I've applied a modified version of your patch (your change broke another junit tests) into
SVN trunk and added a junit test for it.
Could you please verify it is does solve your problem?

> Extra Attributes specified in the Dependency's Module Descriptor are not available to
resolvers
> -----------------------------------------------------------------------------------------------
>
>                 Key: IVY-929
>                 URL: https://issues.apache.org/jira/browse/IVY-929
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0-RC1
>         Environment: Windows
> Java 6
>            Reporter: Scott Hebert
>            Assignee: Maarten Coene
>            Priority: Critical
>             Fix For: trunk
>
>
> {quote}This is a follow up to IVY-773{quote}
> Consider the following IVY file:
> {code:xml}<ivy-module version="1.0">
>     <info organisation="apache" module="extra-att" revision="1.0"/>
>     <dependencies>
> 		<dependency name="mymodule" rev="1748" />
>     </dependencies>
> </ivy-module>
> {code}
> and the corresponding dependency's IVY file:
> {code:xml}
> <ivy-module version="1.0">
>     <info 
>         organisation="apache"
>         module="mymodule"
>         myextraattrib="abc123"
>         revision="1748"
>         status="integration"/>
> 	<publications>
> 		<artifact name="mymodule" platform="windows" type="jar"/>
> 		<artifact name="mymodule" platform="linux" type="jar"/>
> 	</publications>
> </ivy-module>
> {code}
> When a resolver resolves to determine the revision of dependency, it seems that the extra
attribute *myextraattrib* is not available.
> I've narrowed it down to the method in *BasicResolver*:
> {code:java}
>     public ResolvedModuleRevision getDependency(DependencyDescriptor dd, ResolveData
data) {}
> {code}
> where at this point:
> {code:java}
>   rmr = parse(ivyRef, systemDd, data);
> {code}
> *rmr* contains the extra attributes... but at this point:
> {code:xml}
>                         if (systemMd instanceof DefaultModuleDescriptor) {
>                             DefaultModuleDescriptor defaultMd = (DefaultModuleDescriptor)
systemMd;
>                             ModuleRevisionId revision = getRevision(ivyRef, systemMrid,
systemMd);
>                             defaultMd.setModuleRevisionId(revision);
>                             defaultMd.setResolvedModuleRevisionId(revision);
> {code}
> {code:xml}
>                             ModuleRevisionId revision = getRevision(ivyRef, systemMrid,
systemMd);
> {code}
> *revision* is missing the extra attributes.
> I am not familiar enough with the meanings of each of the objects to be able to fix this.
> Thanks
> Scott

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message