ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 45499] DirectoryScanner infinitely recurses on symlinks to parent directories
Date Thu, 04 Sep 2008 07:50:39 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=45499





--- Comment #5 from Stefan Bodewig <bodewig@apache.org>  2008-09-04 00:50:38 PST ---
Matt: yes, I think it is doable, even without too many or too big changes, but
we need to think through some scenarios first to decide what to do.  I'll take
that to the dev list later (after coding up some AntUnit tests as use cases).

Tim: hasBeenScanned only receives the relative path which will be different
each time the directory is encountered again.

I was thinking about a case where we have a structure like this

A/
|---> B/
      |-----> C.txt
      D/
      |-----> E (symlink pointing to A)

Let's say we set basedir to D and scan with an include pattern of E/B/C.txt -
should it match the file or should we skip going upwards (we wouldn't rescan D
since it isn't matched by an include pattern)?  I haven't checked, but we may
even get the file in fast mode and an infinite loop in slow mode (when the
client asks for the not-included files/dirs).

The good thing is that we don't need to think about backwards compatibility for
the cases where Ant could run into an infinite loop 8-)

Like I said, I'll move the discussion over to the dev list.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

Mime
View raw message