ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 23942] Addition of a local property
Date Wed, 02 Jul 2008 17:58:30 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=23942





--- Comment #43 from Matt Benson <gudnabrsam@yahoo.com>  2008-07-02 10:58:29 PST ---
Okay, tossed the heap dump into the Eclipse MAT, which right off told me there
were LocalProperties objects clinging to Project objects, which is why the
patch worked fine in a normal build but broke during test runs because of the
number of Projects and LocalProperties objects being kicked around.  For
example, setting junit.fork=true and junit.forkmode=perTest did away with the
problem nicely.  For the life of me, however, I couldn't see any reason why the
LocalProperties or LocalPropertyStack objects needed a reference to the owning
Project, so I removed it from each class.  The only thing it was being used for
was to ensure there was a single LP per Project, so I simply made the LP
constructor private.  With my modifications, these changes are now working like
a charm.

Ahem... are there any objections to my adding my slightly modified version of
Peter's last patch to the svn trunk?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message