ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik-Berndt Scheper (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IVY-837) Ivy unit tests fail because 'classifier' attribute of 'artifacts' element is missing in ivy.xsd
Date Thu, 12 Jun 2008 10:15:50 GMT

    [ https://issues.apache.org/jira/browse/IVY-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604469#action_12604469
] 

Erik-Berndt Scheper commented on IVY-837:
-----------------------------------------

I have been playing around with the latest trunk version, with the above simple patch for
the classifier. 

The classifier is apparently used to allow importing of "sources" and "javadoc" from a maven
repository, which is definitely desirable. It allows me to differentiate between the various
jar files:
* the jar containing the .class files (without classifier)
* the jar containing .java files (with sources classifier) 
* the jar containing javadocs (with javadoc classifier)
by using the pattern [artifact]-[revision](-[classifier]).[ext]

This could also be achieved with the type attribute, (which contains jar, source, or javadoc),
using [artifact]-[revision]-[type].[ext] but this leads to xxx-1.0-jar.jar, xxx-1.0-javadoc.jar
and xxx-1.0-source.jar which is not very nice compared to xxx-1.0.jar produced by the other
pattern.

Therefore IMHO the classifier should indeed be added as an attribute of the ivy.xsd.

> Ivy unit tests fail because 'classifier' attribute of 'artifacts' element is missing
in ivy.xsd
> -----------------------------------------------------------------------------------------------
>
>                 Key: IVY-837
>                 URL: https://issues.apache.org/jira/browse/IVY-837
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0-RC1
>            Reporter: Erik-Berndt Scheper
>             Fix For: 2.0-RC1
>
>         Attachments: IVY-837-patch.txt
>
>
> Currently the ivy unit tests fail because 'classifier' attribute of 'artifacts' element
is missing in ivy.xsd:
> Test report of class org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParserTest indicates
a failure of testDependenciesWithClassifier:
> {noformat}
> [xml parsing: test-write.xml:23:86: cvc-complex-type.3.2.2: Attribute 'classifier' is
not allowed to appear in element 'artifact'. in file:/D:/java-apps/ivy/build/test/test-write.xml
, xml parsing: test-write.xml:24:87: cvc-complex-type.3.2.2: Attribute 'classifier' is not
allowed to appear in element 'artifact'. in file:/D:/java-apps/ivy/build/test/test-write.xml
]
> java.text.ParseException: [xml parsing: test-write.xml:23:86: cvc-complex-type.3.2.2:
Attribute 'classifier' is not allowed to appear in element 'artifact'. in file:/D:/java-apps/ivy/build/test/test-write.xml
> , xml parsing: test-write.xml:24:87: cvc-complex-type.3.2.2: Attribute 'classifier' is
not allowed to appear in element 'artifact'. in file:/D:/java-apps/ivy/build/test/test-write.xml
> ]
> at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser$AbstractParser.checkErrors(AbstractModuleDescriptorParser.java:89)
> at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser$AbstractParser.getModuleDescriptor(AbstractModuleDescriptorParser.java:342)
> at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorParser.parseDescriptor(XmlModuleDescriptorParser.java:100)
> at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser.parseDescriptor(AbstractModuleDescriptorParser.java:48)
> at org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParserTest.testDependenciesWithClassifier(PomModuleDescriptorParserTest.java:211)
> {noformat}
> Also note that some documentation about the intentions behind this new attribute would
not be amiss.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message