ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44772] New: <patch> task provides no mechanism to fail on error
Date Tue, 08 Apr 2008 00:24:58 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=44772

           Summary: <patch> task provides no mechanism to fail on error
           Product: Ant
           Version: 1.7Alpha (nightly)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core tasks
        AssignedTo: notifications@ant.apache.org
        ReportedBy: mdb@threerings.net


Created an attachment (id=21787)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21787)
A patch that always fails when the patch command fails.

The <patch> task does not fail if the invocation of the patch command fails.

Attached are two patches for <patch>:

1. A patch that simply fails the build when the patch command returns a failure
result code. This patch changes the default behavior of patch to fail when the
patch command fails, which I think is a good thing but may not be the
prevailing wisdom of the Ant project since nearly nothing fails on error by
default.

2. A patch that adds a "failOnError" attribute to the <patch> task which
defaults to false, but when set to true fails the build when the patch command
returns a failure result code.

Actually, it seems that I can only add a single attachment. I will add the
first attachment and then hopefully there will be a way to add additional
attachments once I file this report.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message