ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maarten Coene (JIRA)" <>
Subject [jira] Resolved: (IVY-805) onMissingDescriptor doesn't work due to == comparison
Date Mon, 21 Apr 2008 19:23:21 GMT


Maarten Coene resolved IVY-805.

       Resolution: Fixed
    Fix Version/s: 2.0-RC1

Applied your patch (and added an extra equals... you've forgot to remove one "==") and added
a junit test.
Thanks a lot for your contribution!

> onMissingDescriptor doesn't work due to == comparison
> -----------------------------------------------------
>                 Key: IVY-805
>                 URL:
>             Project: Ivy
>          Issue Type: Bug
>          Components: Ant
>    Affects Versions: 2.0-RC1
>            Reporter: Ben Hale
>            Assignee: Maarten Coene
>             Fix For: 2.0-RC1
>         Attachments: onMissingDescriptor.patch
> In the IvyBuildList file, you compare the value passed for onMissingDescriptor to a set
of constants using the '==' operator.  In Java, this will always return false unless you have
the exact same instance (which is unlikely in this case :))  The code should use the .equals()
method which will return true when strings are identical, even when they are not the same

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message