ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Hale (JIRA)" <>
Subject [jira] Updated: (IVY-805) onMissingDescriptor doesn't work due to == comparison
Date Sat, 19 Apr 2008 17:00:23 GMT


Ben Hale updated IVY-805:

    Attachment: onMissingDescriptor.patch

A patch for the fix.  It's pretty straight forward.  You'll noticed I switched the order of
comparison.  By putting the constant first, you can prevent an NPE when the value set is 'null'.

> onMissingDescriptor doesn't work due to == comparison
> -----------------------------------------------------
>                 Key: IVY-805
>                 URL:
>             Project: Ivy
>          Issue Type: Bug
>          Components: Ant
>    Affects Versions: 2.0-RC1
>            Reporter: Ben Hale
>         Attachments: onMissingDescriptor.patch
> In the IvyBuildList file, you compare the value passed for onMissingDescriptor to a set
of constants using the '==' operator.  In Java, this will always return false unless you have
the exact same instance (which is unlikely in this case :))  The code should use the .equals()
method which will return true when strings are identical, even when they are not the same

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message