ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Woodworth (JIRA)" <>
Subject [jira] Created: (IVY-737) [PATCH] XML entity parsing fix
Date Sat, 16 Feb 2008 10:59:08 GMT
[PATCH] XML entity parsing fix

                 Key: IVY-737
             Project: Ivy
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.0.0-beta-1
            Reporter: Patrick Woodworth

Ivy's parsing of XML files does not properly resolve XML SYSTEM entities.  The problem appears
systemic and widespread, with the underlying cause being the general pattern of always converting
to-be-parsed resources (i.e. URL(s), File(s), etc.) to InputStream(s) before handing them
off to the SAXParser#parse(...) method.  This pattern strips all contextual information about
the source and prevents the parser from properly resolving relative paths to entity sources.

While I believe the problem is widespread and beyond the scope of a first time submitter,
I have managed to create a minimal patch that fixes the issue where it would most often affect
users.  Specifically this patch fixes entity resolution for the parsing of settings.xml and
ivy.xml files that would be found in a source tree as opposed to ivy.xml files that would
be found in repositories.  Another way of looking at it is that my patch fixes entity parsing
for any file that would be parsed by the <ivy:buildlist/> task.

I have also provided a second patch which provides a test-case for this issue, however for
a quick example of what I'm talking about, one can simply look here:

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message