ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (IVY-704) In the ResolveReport class, add the possibility to filter the evicted module while getting the list of DownloadArtifact
Date Fri, 18 Jan 2008 15:33:33 GMT

     [ https://issues.apache.org/jira/browse/IVY-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Xavier Hanin resolved IVY-704.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-beta-2

I've applied your patch with some modifications, thanks a lot for your contribution!

I've made two changes:
- first one is only algorithmic, I changed the way to detect an artifact is evicted in ConfigurationResolveReport
- second is functional, in ResolveReport I include artifacts when withEvicted is false as
soon as the artifact is not evicted in at least one configuration. Hence there is no other
logic in ResolveReport than merging the results from each conf. I find this more logic to
include artifacts even if they are part of an evicted module in one conf and not in another
one, because if they aren't evicted in at least one conf it means they can be used in some
way

I've also done another change after my first commit, this is not directly related to this
issue, but I've changed all Sets and Maps in those two report classes to used Linked versions,
so that order is preserved. This should be better for predictability, especially when used
from IvyDE.

> In the ResolveReport class, add the possibility to filter the evicted module while getting
the list of DownloadArtifact
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: IVY-704
>                 URL: https://issues.apache.org/jira/browse/IVY-704
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Nicolas Lalevée
>             Fix For: 2.0.0-beta-2
>
>         Attachments: IVY-704-r612799.patch
>
>
> As disscussed here : http://mail-archives.apache.org/mod_mbox/ant-dev/200801.mbox/%3c635a05060801160721w7fcd1declaa32803ad3cfbe8c@mail.gmail.com%3e
> In order to get the list of artifacts which are part of the dependencies of a module,
it will be useful to have a function in the ResolveReport class to get the download reports
without the ones from the evited modules.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message