Return-Path: Delivered-To: apmail-ant-notifications-archive@locus.apache.org Received: (qmail 98072 invoked from network); 3 Dec 2007 21:35:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Dec 2007 21:35:04 -0000 Received: (qmail 19084 invoked by uid 500); 3 Dec 2007 21:34:53 -0000 Delivered-To: apmail-ant-notifications-archive@ant.apache.org Received: (qmail 19058 invoked by uid 500); 3 Dec 2007 21:34:53 -0000 Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ant.apache.org Delivered-To: mailing list notifications@ant.apache.org Received: (qmail 19049 invoked by uid 99); 3 Dec 2007 21:34:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2007 13:34:52 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2007 21:34:40 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A9254714236 for ; Mon, 3 Dec 2007 13:34:43 -0800 (PST) Message-ID: <5793981.1196717683682.JavaMail.jira@brutus> Date: Mon, 3 Dec 2007 13:34:43 -0800 (PST) From: =?utf-8?Q?Nicolas_Lalev=C3=A9e_=28JIRA=29?= To: notifications@ant.apache.org Subject: [jira] Updated: (IVYDE-64) Simplify the resolve process MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/IVYDE-64?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Lalev=C3=A9e updated IVYDE-64: --------------------------------- Attachment: IVYDE-64-r600683.patch So here is a new patch. So as discussed, the {{usePreviousResolveIfExist}} = check is kept. And there is still in the patch the eviction of parsing the= report if we already have the artifacts. I think I have mostly made the code simpler to understand. The functionnali= tes of the code are all here, even some error handling (parsing and IO exce= ption which is fallbacking to a complete resolve). I also included in that patch a little part of the patch of IVYDE-43 : use = the IClasspathEntry more than the inner ClasspathItem class. Then the patch may appear quite big. But I am not sure what the indentation= convention are here. I know there is a migration in progress (IVY-511), bu= t the convention doesn't specify if we should use spaces or tabs. I personn= aly prefers spaces, so I used them. Editing with eclipse, it did some stran= ge mix, but I tried to not make the patch appears as a complete diff. I have tested this patch with some ivy-aware project, it works fine. > Simplify the resolve process > ---------------------------- > > Key: IVYDE-64 > URL: https://issues.apache.org/jira/browse/IVYDE-64 > Project: IvyDE > Issue Type: Improvement > Components: classpath container > Affects Versions: 1.3.0 > Environment: trunk r595956 > Reporter: Nicolas Lalev=C3=A9e > Attachments: IVYDE-64-r595956.patch, IVYDE-64-r600683.patch > > > The current trunk, the resolve job is first checking manually if the arti= fact has already been resolved. If not in cache, it let ivy resolve it. And= finally it parses the xml reports in the cache. > So first, as far as I have understood, the manual checking against the ca= che is not needed, ivy already does it. > And then ivy produce in Java some resolve report that already contain eve= ry needed information, there is no need to parse the reports in cache. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.