From notifications-return-360-apmail-ant-notifications-archive=ant.apache.org@ant.apache.org Sun Dec 30 11:47:06 2007 Return-Path: Delivered-To: apmail-ant-notifications-archive@locus.apache.org Received: (qmail 20679 invoked from network); 30 Dec 2007 11:47:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Dec 2007 11:47:06 -0000 Received: (qmail 12230 invoked by uid 500); 30 Dec 2007 11:46:55 -0000 Delivered-To: apmail-ant-notifications-archive@ant.apache.org Received: (qmail 12201 invoked by uid 500); 30 Dec 2007 11:46:55 -0000 Mailing-List: contact notifications-help@ant.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ant.apache.org Delivered-To: mailing list notifications@ant.apache.org Received: (qmail 12192 invoked by uid 99); 30 Dec 2007 11:46:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Dec 2007 03:46:55 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Dec 2007 11:46:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 01AF171422E for ; Sun, 30 Dec 2007 03:46:42 -0800 (PST) Message-ID: <25001095.1199015202995.JavaMail.jira@brutus> Date: Sun, 30 Dec 2007 03:46:42 -0800 (PST) From: =?utf-8?Q?Nicolas_Lalev=C3=A9e_=28JIRA=29?= To: notifications@ant.apache.org Subject: [jira] Updated: (IVYDE-68) IvyDE is using some internal classes of Eclipse In-Reply-To: <17716781.1199014543242.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/IVYDE-68?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Lalev=C3=A9e updated IVYDE-68: --------------------------------- Attachment: IVYDE-68-r607532.patch Here is a patch that fix a part of the bug. In IvydeContainerPage, the use of TypedElementSelectionValidator has been r= eplaced by a simple inner implementation of ISelectionStatusValidator In IvyClasspathUtil, the instanceof check against ClassPathContainer should= be avoided to be replaced by some getAdapter calls. But the internal imple= mentation does not support them. So the code has been change to use some ge= tApdapter functions, but the check against ClassPathContainer has been kept= to kept it working. It might need an opening of a bug in eclipse. IvyClasspathUtil has also been a little refactored so every Actions are get= ting the selection the same way. In IvyClasspathContainer, the instanciation of the ClasspathAttribute is do= ne with the JavaCore static functions. Some change have aslo been done to b= e in sync with the last Ivy API which cache management has changed. In IvyPlugin : the Java model is now got from JavaCore. In OpenIvyFileAction : DialogUtil.openError is simple enought to be copied. The other warnings that have not been fixed in this patch: * FixedJavaSearchPage : of course, as it is a rewrite of an internal behavi= or. * IvyClasspathContainer#notifyUpdateClasspathEntries : there are some use o= f JavaModelManager. I don't know what it is used for, so I didn't change it= . * IvyClasspathInitializer#requestClasspathContainerUpdate : it use JavaDocL= ocations. It seems there is no other way to accomplish it. As the code to c= opy is that trivial, I preferred keep it as is. There are also included some change in the build.xml and build.properties t= o get the last released version of Ivy. I don't know if these changes are s= till useful as the dependency is now handled by Eclipse. I have them locall= y before the dependency changed, so I provide them here, feel free to rever= t them if there are not appropriate. > IvyDE is using some internal classes of Eclipse > ----------------------------------------------- > > Key: IVYDE-68 > URL: https://issues.apache.org/jira/browse/IVYDE-68 > Project: IvyDE > Issue Type: Bug > Affects Versions: 1.3.0 > Reporter: Nicolas Lalev=C3=A9e > Attachments: IVYDE-68-r607532.patch > > > Some classes in IvyDE use come classes which are in some {{org.eclipse...= .internal... }} packages, which should not be used. Compiling IvyDE with Ec= lipse 3.3 raise warning like : > {quote} > Discouraged access: The method containerPut(IJavaProject, IPath, IClasspa= thContainer) from the type JavaModelManager is not accessible due to restri= ction on required library /Users/nicolas/tools/eclipse-3.3/plugins/org.ecli= pse.jdt.core_3.3.1.v_780_R33x.jar=09ivyde/src/java/org/apache/ivyde/eclipse= /cpcontainer=09IvyClasspathContainer.java=09{quote} --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.