ant-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (IVYDE-64) Simplify the resolve process
Date Wed, 05 Dec 2007 02:55:43 GMT

    [ https://issues.apache.org/jira/browse/IVYDE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548519
] 

Xavier Hanin commented on IVYDE-64:
-----------------------------------

I've applied your patch Nicolas, thanks a lot for your contribution!

A couple of changes I made to your patch:
- renamed method retreive to maybeRetrieve, to show in the name that retrieve is not always
called (and fix the typo with ei -> ie, but it's not the only one in IvyDE code)
- put open curly braces on the same line as method declaration for a couple of methods (but
it's not the only style problem we have with IvyDE, the code still needs to be updated with
our code conventions)

About code conventions, using spaces is exactly what we are suppose to do :-) But IvyDE code
has not been cleaned up with a formatter like Ivy has, so it's not very clean.

> Simplify the resolve process
> ----------------------------
>
>                 Key: IVYDE-64
>                 URL: https://issues.apache.org/jira/browse/IVYDE-64
>             Project: IvyDE
>          Issue Type: Improvement
>          Components: classpath container
>    Affects Versions: 1.3.0
>         Environment: trunk r595956
>            Reporter: Nicolas Lalevée
>             Fix For: 1.3.0
>
>         Attachments: IVYDE-64-r595956.patch, IVYDE-64-r600683.patch
>
>
> The current trunk, the resolve job is first checking manually if the artifact has already
been resolved. If not in cache, it let ivy resolve it. And finally it parses the xml reports
in the cache.
> So first, as far as I have understood, the manual checking against the cache is not needed,
ivy already does it.
> And then ivy produce in Java some resolve report that already contain every needed information,
there is no need to parse the reports in cache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message