Mailing-List: contact ivy-user-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ivy-user@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of xavier.hanin@gmail.com
 designates 209.85.146.176 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=CRhTpnxHYnhL/10zoGpKqym4cMFBDzZle2qyNo81y7T/QequTXPqSjalre7JEJnvFbvpQYLRKn9FTnnwxpfd3+bOOiohz4fQMNnkqPYsJiRJGVKmjbrL8rhTPWn9ushHarq07U9V3PNEJtTgjo+gfaQXpCrhOFR88SLsapelULA=
Message-ID: <635a05060707070358y6603ec22g501532870cb4d9af@mail.gmail.com>
Date: Sat, 7 Jul 2007 12:58:36 +0200
From: "Xavier Hanin" <xavier.hanin@gmail.com>
To: ivy-user@incubator.apache.org
Subject: Re: Re[3]: IvyDE 1.2.0/Eclipse 3.2.2: source attachments are working,
 Javadocs are not
In-Reply-To: <1969906143.20070706180153@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_164617_29786760.1183805916238"
References: <683554650.20070705135455@gmail.com>
	 <635a05060707052314p5751c7bai84d4cfc34b6a607a@mail.gmail.com>
	 <1902484152.20070706093248@gmail.com>
	 <1969906143.20070706180153@gmail.com>

------=_Part_164617_29786760.1183805916238
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 7/7/07, Dmitriy Korobskiy <dkroot1@gmail.com> wrote:
>
> Hi, Xavier
>
> DK> Hi, Xavier
> DK> Re: your e-mail from Friday, July 6, 2007 2:14 AM
>
> DK> Thanks a lot! I'll build the trunks specifically to try this fix. This
> issue was
> DK> holding our project from repackaging our repository.
>
> I tried this release today :
> http://www.xoocode.org/downloads/tools/org.apache.ivyde.eclipse_1.3.0.20070706085200.jar


Just to be accurate, this is not a release, but only a build I've made for
my own use. This is NOT an Apache release.

It saved me some time of not getting the trunk and building from source.
>
> The issue (IVYDE-55) is marked as fixed there. I did see the Javadoc
> attachment
> in my test case which was not attaching before, but now it is attaching
> the wrong file -
> the JAR itself, not .javadoc.zip. Source attachment (still) works as
> expected.


This is strange. I admit that I only tested with not declared source and
javadoc (see below)

I'm also curious about the related IVYDE-46 "Support javadoc and sources
> even in
> modules where they are not declared". I've read the issue but it does not
> have
> much detail. How does it work ? Does it mean that the artifact itself is
> used as Javadoc
> and source?


No, I admit the issue is not clear, its purpose is to support maven 2
javadoc and sources. Indeed maven 2 poms do not contain any information
about the availability or not of source and javadoc files. So we can't when
we parse the pom declare source and javadoc artifacts, otherwise Ivy would
raise an error if the artifacts are not present. To have an accurate module
descriptor, we should test the availability of the javadoc and source
artifacts when parsing the pom. This is not trivial, because Ivy module
parser relise on the self containment of the module descriptor, which is not
the case for maven poms. We will have to deal with that in Ivy, but as a
fast way of making source and javadoc attachments working in IvyDE for maven
poms, it's now IvyDE which checks if a javadoc or source artifact is present
even if it isn't declare. But those artifacts have to follow maven
convention.

In your case maybe Ivy think it has found a javadoc file while it's actually
the main artifact. I don't have much time now, maybe you can try to
investigate a little bit yourself by building IvyDE from source and
debugging your use case... You can also reopen IVYDE-55. And I'll try to
find time for this next week.

Xavier

DK> I'm looking forward to have it in a release.
>
> >> On 7/5/07, Dmitriy Korobskiy wrote:
> >>>
> >>> Hi all,
> >>>
> >>> There were previous discussions on this list about source and Javadoc
> >>> attachments. I was able to make source attachments work, using double
> >>> extensions, but could not make Javadocs work.
> >>>
> >>> Here is the test case I have isolated:
> >>>
> >>> 1. IvyDE preferences:
> >>>
> >>> Accepted types = jar,zip
> >>> Sources types = src
> >>> Javadoc types = javadoc
> >>>
> >>> 2. Repository:
> >>>
> >>> <HOME>\apache\commons-collections\commons-
> >>> collections-3.2\commons-collections-3.2.jar
> >>> <HOME>\apache\commons-collections\commons-
> >>> collections-3.2\commons-collections-3.2.javadoc.zip
> >>> <HOME>\apache\commons-collections\commons-
> >>> collections-3.2\commons-collections-3.2.src.zip
> >>>
> >>> 3. Ivy file for Apache Commons 3.2:
> >>>
> >>> <?xml version="1.0"?>
> >>> <?xml-stylesheet type="text/xsl" href="ivy-doc.xsl"?>
> >>> <ivy-module version="1.4" xmlns:xsi="
> >>> http://www.w3.org/2001/XMLSchema-instance"
> xsi:noNamespaceSchemaLocation="
> >>> ivy.xsd">
> >>>   <info organisation="apache" module="commons-collections" revision="
> 3.2"
> >>> status="release"/>
> >>>   <configurations>
> >>>     <conf name="default"/>
> >>>     <conf name="ide" description="JavaDoc and sources"/>
> >>>   </configurations>
> >>>   <publications>
> >>>     <artifact name="commons-collections" type="jar"
> conf="default,ide"/>
> >>>     <artifact name="commons-collections" type="src" ext="src.zip"
> >>> conf="ide"/>
> >>>     <artifact name="commons-collections" type="javadoc" ext="
> javadoc.zip"
> >>> conf="ide"/>
> >>>   </publications>
> >>> </ivy-module>
> >>>
> >>> 4. Project Ivy file (I have simplified it a bit for this test case by
> >>> removing
> >>> unnecessary parts):
> >>>
> >>> <?xml version="1.0"?>
> >>> <ivy-module version="1.3" xmlns:xsi="
> >>> http://www.w3.org/2001/XMLSchema-instance"
> xsi:noNamespaceSchemaLocation="
> >>> http://incubator.apache.org/ivy/schemas/ivy.xsd">
> >>>   <info organisation="DK" module="samplesj2ee"/>
> >>>   <configurations>
> >>>     <!--conf name="compile"/-->
> >>>     <!-- conf name="ide" extends="compile"/ -->
> >>>     <conf name="ide"/>
> >>>   </configurations>
> >>>   <!--dependencies defaultconf="compile->default;ide->ide(default)"
> -->
> >>>   <dependencies>
> >>>     <dependency org="apache" name="commons-collections" rev="3.2"
> >>> conf="ide"/>
> >>>   </dependencies>
> >>> </ivy-module>
> >>>
> >>> 5. Now, when I add Ivy library to a project, I have sources
> successfully
> >>> attached,
> >>> but Javadocs are not.
> >>>
> >>> If anybody made it work (which was mentioned in some previous
> threads), I
> >>> wonder
> >>> what setup worked for you and what is not working in the setup above.
>
>
> >> Indeed, I've never had the javadoc working either; but didn't really
> care,
> >> since it only prevent from opening external javadoc when you have
> source
> >> attached. But I'm currently investigating on this issue and I think
> I've
> >> found the problem. I'll check in a fix in a moment, but it will only be
> >> available on IvyDE trunk (which works with Ivy trunk).
>
> >> Xavier
>
>
>
> Dmitriy <1-127-441 @ICQ, DKroot @Skype>
> <DKroot1 @AIM, dkroot1_at_gmail_dot_com @Google Talk or @MSN, dk_root
> @Yahoo>
>
>


-- 
Xavier Hanin - Independent Java Consultant
http://xhab.blogspot.com/
http://incubator.apache.org/ivy/
http://www.xoocode.org/

------=_Part_164617_29786760.1183805916238--