Return-Path: Delivered-To: apmail-incubator-ivy-user-archive@locus.apache.org Received: (qmail 32506 invoked from network); 24 Apr 2007 16:53:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Apr 2007 16:53:38 -0000 Received: (qmail 54961 invoked by uid 500); 24 Apr 2007 16:53:45 -0000 Delivered-To: apmail-incubator-ivy-user-archive@incubator.apache.org Received: (qmail 54944 invoked by uid 500); 24 Apr 2007 16:53:44 -0000 Mailing-List: contact ivy-user-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ivy-user@incubator.apache.org Delivered-To: mailing list ivy-user@incubator.apache.org Received: (qmail 54935 invoked by uid 99); 24 Apr 2007 16:53:44 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2007 09:53:44 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [209.191.106.90] (HELO web39506.mail.mud.yahoo.com) (209.191.106.90) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 24 Apr 2007 09:53:36 -0700 Received: (qmail 4279 invoked by uid 60001); 24 Apr 2007 16:53:15 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=6Ej6kDgKFr7zdV/i2HXZhEWd6GgTUSUNgpElLuFNErXJAvdty82BMILy4WFsIW4pLlbZkCTOkyYE2eZ/m+16Vxum0tfcvIKfGQZISswyFbj/PQdnKCa4y+5sribyBMTPftkXnbn8nPW3LdqZBsleGEhefudYlgtGN9Bj2U5JsMo=; X-YMail-OSG: w8wybEwVM1l.Jl5U1QUCO4iSOPrLpR_roOCMj4Ztxg95CWe6QTIo2VmOgNuu_P66QgQfSq2vWN4vxyvstUNavmtLM8CEQDRgyCrwft51FbkV5EVdVkJhW0PWuY9yoA-- Received: from [192.18.123.36] by web39506.mail.mud.yahoo.com via HTTP; Tue, 24 Apr 2007 09:53:15 PDT Date: Tue, 24 Apr 2007 09:53:15 -0700 (PDT) From: jeff Subject: Re: code review please: issue 475 To: ivy-user@incubator.apache.org In-Reply-To: <635a05060704232314x51d326dq150b2c387d2f08c1@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="0-52990074-1177433595=:4020" Content-Transfer-Encoding: 8bit Message-ID: <252891.4020.qm@web39506.mail.mud.yahoo.com> X-Virus-Checked: Checked by ClamAV on apache.org --0-52990074-1177433595=:4020 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit xavier, i've already signed the apache contributor agreements and i've contributed code to other project. please feel free to check up on that. regardless, i attached the patch to the issue also (which makes more sense anyway). i actually attached it twice, as the first time i didn't check the "grant license" checkbox, which i assume is relevant. thanks! Xavier Hanin wrote: On 4/23/07, jeff wrote: > > *Xavier Hanin * wrote: > > > I don't know apache rules very well, but I would be surprised if you have > write access to our project. Indeed AFAIK commiting directly is considered > as being a commiter, which requires a vote in our PPMC. > > i suspect i have write access, because when i was approved for another > project, it was just "apache svn write access", and not specific to the > project. but ya, i don't really know how apache works it either. > > but anyway, i realize i am not a committer on this project so i won't even > try. i am attaching a patch file. would you mind applying it? i'd really > like this to be in the next release, so if you have a 2.x release branch, > could you put it there, as well as the trunk? For attaching the patch I'd prefer using the issue in JIRA. I don't know Apache rules well enough to be sure, but I know that there is no problem to apply patches when they are attached in JIRA with the checkbox saying it's a contribution. It's also easier to keep track of your contribution. And about the branch, 2.0 developments are occurring on the trunk, so no problem. Cheers, Xavier > thanks! > > ------------------------------ > Ahhh...imagining that irresistible "new car" smell? > Check out new cars at Yahoo! Autos. > > -- Learn Ivy at ApacheCon: http://www.eu.apachecon.com/ Manage your dependencies with Ivy! http://incubator.apache.org/ivy/ --------------------------------- Ahhh...imagining that irresistible "new car" smell? Check outnew cars at Yahoo! Autos. --0-52990074-1177433595=:4020--