ant-ivy-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeff <>
Subject code review please: issue 475
Date Sat, 21 Apr 2007 07:58:02 GMT

could someone review this fix?

essentially, i added a check in IvyInstall to see if there are any unresolved dependencies,
and if so, throw a BuildException. this is the default behavior, but it can be over ridden
by setting haltunresolved=false on the install task.

i also added a new test class, IvyInstallTest, that tests the missing dependency case for
haltunresolved true and false.

also, i found another test case that was failing. see line 117 for
the failed test, and (diffs) for the fix.

diffs attached, thanks.

p.s., i do have apache SVN write access, which i think applies to all projects? so if it's
okay here, should be able to commit myself, if the change is acceptable. 

Ahhh...imagining that irresistible "new car" smell?
 Check outnew cars at Yahoo! Autos.
  • Unnamed multipart/mixed (inline, 8-Bit, 0 bytes)
View raw message