ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [1/2] ant git commit: Simplify tests, use Charset
Date Mon, 12 Nov 2018 18:04:43 GMT
On 2018-11-11, <gintas@apache.org> wrote:

>+     * Construct a <code>ReaderInputStream</code>
>+     * for the specified <code>Reader</code>,
>+     * with the specified encoding.
>+     *
>+     * @param reader     non-null <code>Reader</code>.
>+     * @param charset    non-null <code>Charset</code> charset.
>+     */
>+    public ReaderInputStream(Reader reader, Charset charset) {

please add a @since marker.

>>        if (charset == null) {
>>            throw new IllegalArgumentException("encoding must not be null");

s/encoding/charset/

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message