ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] ant pull request #79: Make DataType and Reference generic
Date Mon, 12 Nov 2018 13:59:07 GMT
Github user bodewig commented on a diff in the pull request:

    https://github.com/apache/ant/pull/79#discussion_r232666118
  
    --- Diff: src/main/org/apache/tools/ant/types/AbstractFileSet.java ---
    @@ -915,7 +920,7 @@ public String toString() {
         @Override
         public synchronized Object clone() {
             if (isReference()) {
    -            return (getRef(getProject())).clone();
    +            return getRef(getProject()).clone();
    --- End diff --
    
    please keep style changes separate from PRs (or better just don't create them at all)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message