ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gintautas Grigelionis <g.grigelio...@gmail.com>
Subject Re: Tests in Surefire
Date Mon, 22 Oct 2018 14:45:30 GMT
Here's what happened: there's a Jenkins job that builds Ant using Maven,
since Ant project has POMs for all components.

I happened to create a new component, and realised I forgot to add it to
the master POM.
While doing that, I saw that the Jenkins job has been broken, and started
digging deeper.
It seems that once upon a time Ant was buildable with Maven including unit
tests
(even though the latter part was cludgy, mainly because the launcher sets
some magical properties,
but also due to limitations in earlier versions of Surefire).

However, running the tests independently through Surefire would help to
improve them,
partly because that would expose all magic that's happening under the cover,
and partly because the exclude/include rules are degraded to the point that
apache-ant Maven module
still tries to execute too many tests, while some tests (like those for ssh
task) seems to be ignored by pure Ant builds.

In order to get this sorted out, I came to the conclusion that I would like
BuildFileTest/BuildFileRule
to clear basedir property based on whether another magic property is set or
not before project.init() in configureProject().
I propose to call it "ant.test.basedir.ignore" or something like that; I
can open a PR for that.

Gintas

On Mon, 22 Oct 2018 at 07:34, Jaikiran Pai <jaikiran@apache.org> wrote:

> Could you tell us a bit more about what is being attempted? Are you
> saying you plan to run the tests that are part of the Ant project,
> through the mvn command, while building Ant?
>
> -Jaikiran
>
>
> On 20/10/18 3:31 PM, Gintautas Grigelionis wrote:
> > I believe that in order to execute Ant test suite in Surefire one must
> > configure basedir which unfortunately affects Ant test projects. Perhaps
> it
> > would make sense to have a magic property that (in combination with
> > detection of Surefire environment) would allow BuildFileRule to call
> > System.clearProperty("basedir")?
> >
> > Gintas
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message