ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: ant git commit: Remove redundancies
Date Wed, 22 Aug 2018 18:53:06 GMT
Pretty much every implementation of javac will automatically convert the
string concatenation code into StringBuilders. Decompile the byte code and
see for yourself.

On Tue, 21 Aug 2018 at 13:05, Stefan Bodewig <bodewig@apache.org> wrote:

>
> > diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java
> b/src/main/org/apache/tools/ant/types/PatternSet.java
>
> > -                : new
> StringBuilder(baseString).append(";encoding->").append(encoding).toString();
> > +                : baseString + ";encoding->" + encoding;
>
> I don't understand what kind of redundancy have you been removing here.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

-- 
Matt Sicker <boards@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message