ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: FileUtils.normalize/isLeadingPath have bitten me
Date Sun, 01 Jul 2018 09:27:33 GMT
On 2018-06-28, Stefan Bodewig wrote:

> On 2018-06-28, Jaikiran Pai wrote:

>> Which then makes me wonder - in the context of this specific
>> untar/expand/unzip issue, should we probably be using a different
>> custom very specific logic (which relies on canonical files and
>> getParent()) instead of a call to isLeadingPath()?

> Probably. I used isLeadingPath because it has been already there - and )
> simply didn't realize it wouldn't do what I expected it to.

I decided to "fix" isLeadingPath for this edge case and add a method
using canonical paths instead - and use that in unzip and friends.

Please have a look at the proposed solution, I won't close the Bugzilla
issue before we have agreed this is the proper fix.

Cheers

        Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message