From dev-return-90584-archive-asf-public=cust-asf.ponee.io@ant.apache.org Wed Feb 14 05:34:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 22AC4180656 for ; Wed, 14 Feb 2018 05:34:08 +0100 (CET) Received: (qmail 34106 invoked by uid 500); 14 Feb 2018 04:34:07 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 34090 invoked by uid 99); 14 Feb 2018 04:34:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 04:34:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 80DD01A0501 for ; Wed, 14 Feb 2018 04:34:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.148 X-Spam-Level: X-Spam-Status: No, score=0.148 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FQl3OKx89d9x for ; Wed, 14 Feb 2018 04:34:04 +0000 (UTC) Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 3FB0C5F232 for ; Wed, 14 Feb 2018 04:34:04 +0000 (UTC) Received: by mail-pf0-f175.google.com with SMTP id b62so3447464pfk.10 for ; Tue, 13 Feb 2018 20:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=s+ex795/FJTnoF12bh5ivmneyP0kFoX+brfWcLEjEjU=; b=vAvZm4aIm3E1zCsLrLz/8B5nYwGAsF16Vc8Wlx9Ib+dpPVmjaeslS/VU0G2/wu9CB5 hHY72sC+6RCbg5WrrTYfSymjEbo3WyACANApt/xVn6Xba14VzCJknLC1UzYw2biqnxY9 nqR17zo4RH59ShYI5YvQVYLTOJkN/Xbb5xihl/XtgdyapD24Woe54DSAwwwrnaP/XGVY hj2RmESTevNELmcWaeS6CCOV2z2PCidsoiutVSv+kRv1tPYYg1uGc9vF5TEa8NQBEopn QynGqRZJ7jaUK22nZ2J44Spz0EkI7FlorbTcGkMTcSq2c6eGhiZdPlJ6q8NKprTdegG8 K65w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=s+ex795/FJTnoF12bh5ivmneyP0kFoX+brfWcLEjEjU=; b=Tlo+Dm8ry6HFrt8XzngfQcjT8nc17IbBeZx+Wiw7ini0pvbaFbfyyLYhd1NUzqFQ2D /ezbxcYpLuNApMMVQ/mpUyaa6qNu0FnL7a8MSaChxRt3wpc2J+FeiERkSDhjLmueY7HT M/jzviWvI5U5T9654QTjyG+q2v+xiq54wBMeVridCMUiW8R3bUMjEeSEwJ3u8HtMOV5H jQ73Ayrj78nmzGA1mQZmUIcKBjGy4BbZWA2begUvzp40o8l+6e3siMmB4usNzSoKWaIy 0Fx02NFNZBdqleA9/YjRxh7yUimO7w2MXRnEBasGwyxHAG+gym0j37FM1Qachoo+gLmC uiTA== X-Gm-Message-State: APf1xPDJyPdOcUymjHB9qfPt7RA1Y0U5MqatB2cDj7AN+jAk/gviovCY 4azbt2yrkOTY+RE1kRXvd6rS1sZ+ X-Google-Smtp-Source: AH8x225rhGgc3RFHqa+FvaHnzOkOZuYkj3ZnG1sSwv+NlnbF5P4d4MeEel66a6VS5I3X/JS37VxFZQ== X-Received: by 10.99.117.26 with SMTP id q26mr2955143pgc.46.1518582836799; Tue, 13 Feb 2018 20:33:56 -0800 (PST) Received: from whiteoffice.local ([223.227.1.61]) by smtp.gmail.com with ESMTPSA id c185sm36904807pfb.146.2018.02.13.20.33.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 20:33:56 -0800 (PST) From: Jaikiran Pai X-Google-Original-From: Jaikiran Pai Subject: Re: Need a Second Pair of Eyes To: dev@ant.apache.org References: <87bmgseq47.fsf@v45346.1blu.de> <911cebeb-38bb-2f7c-f008-a2d7ab2c1d99@apache.org> Message-ID: Date: Wed, 14 Feb 2018 10:03:53 +0530 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <911cebeb-38bb-2f7c-f008-a2d7ab2c1d99@apache.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US I forgot to add that, as you note, as a result of the change, the new created path will retain all elements from destPath that aren't in dependClassPath, which is unlike the behaviour before the change. -Jaikiran On 14/02/18 9:59 AM, Jaikiran Pai wrote: > Hi Stefan, > > You are right. The change introduces a different behaviour than what > was there before. Just to be extra sure that we indeed are reading it > right, I added a (dummy) test case in my personal repo, which compares > the previous logic and the new logic and it does shows that the change > indeed introduces a different behaviour. > > [1] > https://github.com/jaikiran/ant/commit/f57b9d5fbca6e9648695bc9d37a27000c0b4aff2#diff-585ed59cf64ef6930e5148094adc322aR21 > > -Jaikiran > > > On 13/02/18 11:20 PM, Stefan Bodewig wrote: >> Hi all >> >> I'm currently reviewing the big change that introduced the regression in >> 1.10.2 as we may have overlooked more than this issue. It is a *big* >> change and so it is taking time. >> >> While looking at the hunk starting at >> >> https://github.com/apache/ant/commit/b7d1e9bde44cb8e5233d6e70bb96e14cbb2f3e2d#diff-3cabe19d89e908d993d999100d888b6eL256 >> >> >> I think the buildup of the path is now backwards. >> >> The original code would add all elements of dependClasspath to the path >> that are not members of destPath to the new Path p. Unless I am mistaken >> the Difference created in the new code will in addition retain all >> elements of destPath that are not in dependClasspath. So we get all >> elements that are in exactly one of the two - which is more than we >> would have with the old code unless destPath is a subset of >> dependClasspath. >> >> Does anybody else read it the same way? Or can tell me I'm wrong? >> >> Unfortunately our test coverage for the depend task is so close to >> non-existent that we can't tell from the tests whether we've broken >> anything. >> >> Stefan >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org >> For additional commands, e-mail: dev-help@ant.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org