From dev-return-90569-archive-asf-public=cust-asf.ponee.io@ant.apache.org Fri Feb 9 18:06:20 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E5832180654 for ; Fri, 9 Feb 2018 18:06:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D4CB5160C66; Fri, 9 Feb 2018 17:06:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4DE13160C65 for ; Fri, 9 Feb 2018 18:06:20 +0100 (CET) Received: (qmail 48766 invoked by uid 500); 9 Feb 2018 17:06:19 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 48755 invoked by uid 99); 9 Feb 2018 17:06:19 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Feb 2018 17:06:19 +0000 Received: from v45346.1blu.de (v45346.1blu.de [178.254.23.72]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 56FFA28EB for ; Fri, 9 Feb 2018 17:06:17 +0000 (UTC) Received: by v45346.1blu.de (Postfix, from userid 1000) id 7E195400A01; Fri, 9 Feb 2018 18:06:11 +0100 (CET) From: Stefan Bodewig To: dev@ant.apache.org Subject: Re: Mapped resources NPEs - Potential fix causes a failure in one specific test References: <4dd9673e-08b0-8f78-6d82-5c0e6fcf0ef7@apache.org> Date: Fri, 09 Feb 2018 18:06:11 +0100 In-Reply-To: <4dd9673e-08b0-8f78-6d82-5c0e6fcf0ef7@apache.org> (Jaikiran Pai's message of "Fri, 9 Feb 2018 14:36:37 +0530") Message-ID: <87shaa14ak.fsf@v45346.1blu.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain On 2018-02-09, Jaikiran Pai wrote: > That test was introduced long back as part of [5] to test another > similar NPE. I think with the change I now have, it no longer reaches > this place in the code where the Copy task would end up getting a null > from a mapper, because various other utility classes already handle > this contract and skip that resource. I completely agree with your fix. What this specific test failure shows, though, is that we now no longer are able to distinguish between a resource that we could copy but can't because it doesn't provide a name and the case of "all resources have been stripped out by mappers as "I don't know how to handle it". Unfortunately I don't see any way to distinguish between "all resources have been excluded by mappers" and "all resources have been up to date" and certainly not how to figure out a resource didn't have a name when we want to allow such resources if followed by a merge mapper. I'm fine with removing the test but would want us to document the change in behavior. Where a resource with a null name used to cause a build exception it will now be silently ignored by copy. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org